Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use podname for EventPanel name param (#10051) #10052

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

fsiegmund
Copy link
Contributor

Signed-off-by: fsiegmund siegmund@slb.com

Fixes #10051

Signed-off-by: fsiegmund <siegmund@slb.com>
@fsiegmund fsiegmund marked this pull request as ready for review November 17, 2022 12:01
@fsiegmund
Copy link
Contributor Author

Fix is in addition to #6925

Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
(note: the bug was due podname v2, nodeid used to be same as podname)

@terrytangyuan terrytangyuan merged commit 74766d5 into argoproj:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event viewer UI not showing events for retriable worksteps
3 participants